Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card] Refresh of component's UI and its API #390

Closed
sgraczyk opened this issue Aug 10, 2022 · 1 comment · Fixed by #397
Closed

[Card] Refresh of component's UI and its API #390

sgraczyk opened this issue Aug 10, 2022 · 1 comment · Fixed by #397
Assignees
@sgraczyk
Labels
feature New feature or request

Comments

@sgraczyk
Copy link

sgraczyk commented Aug 10, 2022 •
edited
Loading

Description

Current implementation of the Card component is most likely a direct migration from the legacy version. At this point, it is quite different from Figma designs. General changes to be applied:

  • image size from 24x24 to 48x48
  • custom actions should be available as props
  • a divider is required to separate actions from content
  • content should be loadable, therefore a loading state is required
  • upper right corner should allow for an action (edit) button
  • when the content is too long and we handle it with an ellipsis there should be a tooltip when hovering on the exact content

Design

Figma
@sgraczyk sgraczyk added the feature New feature or request label Aug 10, 2022
@sgraczyk sgraczyk added this to the v1.0.0 milestone Aug 10, 2022
@sgraczyk sgraczyk moved this to Selected for Development in LiveChat Design System Aug 10, 2022
@sgraczyk sgraczyk changed the title [Card] UI refresh of component and its API [Card] Refresh of component UI and its API Aug 10, 2022
@sgraczyk sgraczyk changed the title [Card] Refresh of component UI and its API [Card] Refresh of component's UI and its API Aug 10, 2022
@sgraczyk sgraczyk self-assigned this Aug 10, 2022
@sgraczyk sgraczyk moved this from Selected for Development to In Progress in LiveChat Design System Aug 10, 2022
sgraczyk pushed a commit that referenced this issue Aug 26, 2022
#390 Card component refactoring
8e28d70
@sgraczyk sgraczyk mentioned this issue Aug 26, 2022
Merged
6 tasks
@sgraczyk sgraczyk moved this from In Progress to In Review in LiveChat Design System Aug 26, 2022
sgraczyk pushed a commit that referenced this issue Aug 29, 2022
#390 Card component refactoring
6d00b8b
This was linked to pull requests Aug 30, 2022
#390 Card component refactoring #397
Merged
#332 z-index for Popover component #398
Merged
@sgraczyk sgraczyk removed a link to a pull request Aug 30, 2022
#332 z-index for Popover component #398
Merged
6 tasks
sgraczyk pushed a commit that referenced this issue Sep 5, 2022
#390 Card component refactoring (#397)
db02792
@sgraczyk sgraczyk moved this from In Review to Done in LiveChat Design System Sep 12, 2022
@sgraczyk
Copy link
Author

Released in v1.0.0-alpha.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgraczyk sgraczyk

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#390 Card component refactoring livechat/design-system
1 participant
@sgraczyk