Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-release versions in attached runtime version check #2905

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Allow pre-release versions in attached runtime version check #2905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/livebook/runtime/attached.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,13 @@ defmodule Livebook.Runtime.Attached do
# changes are unlikely within the same minor version, so that's
# the requirement we enforce.

current = Version.parse!(System.version())
same_minor = "#{current.major}.#{current.minor}.0"
current = System.version()

same_minor =
current
|> Version.parse!()
|> Map.replace!(:patch, 0)
|> Version.to_string()

# Make sure Livebook does not enforce a higher patch version
min_version =
Expand Down
Loading