Allow pre-release versions in attached runtime version check #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SteffenDE
force-pushed
the
sd-allow-pre
branch
from
fe20a59 to
a4c55db
Compare
lib/livebook/runtime/attached.ex
Outdated
Comment on lines
94
to
95
| current = Version.parse!(System.version()) | ||
| same_minor = "#{current.major}.#{current.minor}.0" | ||
| same_minor = "#{current.major}.#{current.minor}.0-dev" |
There was a problem hiding this comment.
What about this?
current = System.version()
same_minor =
current
|> Version.parse!()
|> Map.replace!(:patch, 0)
|> Version.to_string()This means that if Livebook is running on -dev, we include -dev in the requirement, otherwise we don't.
If the user is not used to running Elixir main, showing -dev in the error message may be unnecessarily confusing.
(Note the intentional current = System.version(), it's expected to be a string below, currently it is a bug)
Co-Authored-By: Jonatan Kłosko <[email protected]>
SteffenDE
force-pushed
the
sd-allow-pre
branch
from
a4c55db to
ef8b77f
Compare
jonatanklosko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often run with the most recent Elixir version from GitHub locally. Currently Livebook does not allow connecting nodes both running
1.19.0-devbecauseThis PR changes the minor check to include a
-devsuffix. I think any suffix would do, but that's what Elixir uses.