Refactor assignments #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 25, 2018
|
I am OK with the changes. @razvand for the next patches please use tags for commit message. Like for example: Documentation: labs: ... |
alexandrasandulescu
approved these changes
Mar 26, 2018
Signed-off-by: Razvan Deaconescu <[email protected]>
|
@alexandrasandulescu , do you think we should remove the numbering prefix and leave only the assignment name as it was in the old repository (i.e. use |
…ignment Signed-off-by: Razvan Deaconescu <[email protected]>
…-list Signed-off-by: Razvan Deaconescu <[email protected]>
… assigments/ subfolder Signed-off-by: Razvan Deaconescu <[email protected]>
|
@dbaluta, so it should be as below? Is there a guideline for this? |
|
@razvand I would suggest to keep the prefixes for both repo and vmchecker, or remove them everywhere. Maybe we could do this in a separate PR. |
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 26, 2018
|
@alexandrasandulescu, OK, we'll keep prefixes for the time being. Please do the same for the next assignments. |
|
@razvand adding tags to commit message is a common practice in the Linux kernel. If not sure what tag to use just see git log around the directory / file you changed and use the tags from previous commits. |
dbaluta
approved these changes
Mar 26, 2018
|
@dbaluta, I've added the |
tavip
pushed a commit
to linux-kernel-labs/linux-kernel-labs.github.io
that referenced
this pull request
Mar 26, 2018
dbaluta
pushed a commit
to dbaluta/linux
that referenced
this pull request
Jun 5, 2019
WARNING: Prefer 'unsigned int' to bare use of 'unsigned' linux-kernel-labs#42: FILE: fs/ocfs2/aops.c:2155: + unsigned i_blkbits = inode->i_sb->s_blocksize_bits; ERROR: code indent should use tabs where possible linux-kernel-labs#53: FILE: fs/ocfs2/aops.c:2166: + ^I * "pos" and "end", we need map twice to return different buffer state:$ WARNING: please, no space before tabs linux-kernel-labs#53: FILE: fs/ocfs2/aops.c:2166: + ^I * "pos" and "end", we need map twice to return different buffer state:$ ERROR: code indent should use tabs where possible linux-kernel-labs#54: FILE: fs/ocfs2/aops.c:2167: + ^I * 1. area in file size, not set NEW;$ WARNING: please, no space before tabs linux-kernel-labs#54: FILE: fs/ocfs2/aops.c:2167: + ^I * 1. area in file size, not set NEW;$ ERROR: code indent should use tabs where possible linux-kernel-labs#55: FILE: fs/ocfs2/aops.c:2168: + ^I * 2. area out file size, set NEW.$ WARNING: please, no space before tabs linux-kernel-labs#55: FILE: fs/ocfs2/aops.c:2168: + ^I * 2. area out file size, set NEW.$ ERROR: code indent should use tabs where possible linux-kernel-labs#56: FILE: fs/ocfs2/aops.c:2169: + ^I *$ WARNING: please, no space before tabs linux-kernel-labs#56: FILE: fs/ocfs2/aops.c:2169: + ^I *$ ERROR: code indent should use tabs where possible linux-kernel-labs#57: FILE: fs/ocfs2/aops.c:2170: + ^I *^I^I iblock endblk$ WARNING: please, no space before tabs linux-kernel-labs#57: FILE: fs/ocfs2/aops.c:2170: + ^I *^I^I iblock endblk$ ERROR: code indent should use tabs where possible linux-kernel-labs#58: FILE: fs/ocfs2/aops.c:2171: + ^I * |--------|---------|---------|---------$ WARNING: please, no space before tabs linux-kernel-labs#58: FILE: fs/ocfs2/aops.c:2171: + ^I * |--------|---------|---------|---------$ ERROR: code indent should use tabs where possible linux-kernel-labs#59: FILE: fs/ocfs2/aops.c:2172: + ^I * |<-------area in file------->|$ WARNING: please, no space before tabs linux-kernel-labs#59: FILE: fs/ocfs2/aops.c:2172: + ^I * |<-------area in file------->|$ ERROR: code indent should use tabs where possible linux-kernel-labs#60: FILE: fs/ocfs2/aops.c:2173: + ^I */$ WARNING: please, no space before tabs linux-kernel-labs#60: FILE: fs/ocfs2/aops.c:2173: + ^I */$ total: 8 errors, 9 warnings, 40 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/ocfs2-clear-zero-in-unaligned-direct-io.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jia Guo <[email protected]> Cc: Yiwen Jiang <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Stephen Rothwell <[email protected]>
dbaluta
pushed a commit
to dbaluta/linux
that referenced
this pull request
Jun 5, 2019
…igger after channel disabled edma interrupt may come after channel terminated, so should ignore interrupts, else kernel crash as below since fsl_chan->edesc set to NULL when terminate. 606.837306] Unable to handle kernel NULL pointer dereference at virtual address 00000060 [ 606.845411] pgd = ffff000009295000 [ 606.848814] [00000060] *pgd=00000008bfffe003[ 606.852906] , *pud=00000008bfffd003 , *pmd=0000000000000000[ 606.858395] [ 606.859885] Internal error: Oops: 96000006 1 PREEMPT SMP [ 606.865460] Modules linked in: [ 606.868522] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.9.11-03371-g9904ea0 linux-kernel-labs#42 [ 606.875832] Hardware name: Freescale i.MX8QXP LPDDR4 ARM2 (DT) [ 606.881662] task: ffff000009120680 task.stack: ffff000009110000 [ 606.887588] PC is at fsl_edma3_tx_handler+0x50/0x150 Signed-off-by: Robin Gong <[email protected]> Tested-by: Daniel Baluta <[email protected]> (cherry picked from commit 625afad5a0900bc3e3288510f61647b1d891a5a4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made an update to the file system structure for assignments templates. This is currently used in vmchecker. @alexandrasandulescu , please take a look. Is this OK with you?
We can remove the numbering prefix (i.e. use
tracerinstead of1-tracer); this will require an updated to theconfigfile in vmchecker.