Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): fixes for make setup #34

Closed
wants to merge 1 commit into from
Closed

fix(setup): fixes for make setup #34

wants to merge 1 commit into from

Conversation

noelmcloughlin
Copy link
Contributor

This PR seems to fix the following issues with make setup procedure:

  1. Makefile bad substitution (and remove some trailing white spaces)
  2. poetry install complaining not a git project #33
(baselink-py3.10) ~/git/hub/projects/baselink/baselink$ make setup
./utils/get-value.sh: 4: Bad substitution
./utils/get-value.sh: 4: Bad substitution
poetry install

This does not appear to be a Git project

@cmungall cmungall requested a review from sierra-moxon January 17, 2023 17:46
@noelmcloughlin
Copy link
Contributor Author

noelmcloughlin commented Jan 17, 2023

Unfortunately my PR solves Step 4 but breaks Step 8 due to nested .git/ directories.

Step 4: Run git init in directory ./linkml-projects/ solves #33 OK
Step 5: OK
Step 6: OK
Step 7: OK
Step 8: NOK

cd  ./linkml-projects/my-awesome-schema/
git remote add origin https://github.com/my-user-or-organization/my-awesome-schema.git
git branch -M main
git push -u origin main

error: 'main/' does not have a commit checked out

The solution for Step 8 is unsatisfying but effective!!

rm -fr ../.git               #  revert what we done for step 4 = fix the error above
git remote add origin https://github.com/my-user-or-organization/my-awesome-schema.git
git branch -M main
git push -u origin main

Suggestions welcome!

@cmungall
Copy link
Member

I think the changes to the Makefile are good - maybe separate these out?

As for the README instructions, I think we need to revisit these as a whole as getting setup is still more complex than it needs to be

@noelmcloughlin
Copy link
Contributor Author

Closed for now: #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants