add node affinity to linkerd-viz #10947
Conversation
Signed-off-by: jrsalgado <[email protected]>
Signed-off-by: jrsalgado <[email protected]>
Signed-off-by: jrsalgado <[email protected]>
Signed-off-by: jrsalgado <[email protected]>
Signed-off-by: Fernando Reyes <[email protected]>
Signed-off-by: Fernando Reyes <[email protected]>
Signed-off-by: Fernando Reyes <[email protected]>
There was a problem hiding this comment.
Thanks @reyes256 👍
The PR description mentions Jaeger, but the changes are about linkerd-viz. Can you amend that?
Viz' values.yaml already contains a global nodeAffinity entry (commented out). Can you remove it?
For completeness sake, can you add nodeAffinity to the tap, tapInjector and dashboard components as well?
| @@ -71,9 +71,10 @@ spec: | |||
| {{- include "linkerd.tolerations" (dict "Values" .Values.metricsAPI) | nindent 6 }} | |||
| {{- end -}} | |||
| {{- include "linkerd.node-selector" (dict "Values" .Values.metricsAPI) | nindent 6 }} | |||
| {{- include "linkerd.affinity" (dict "Values" .Values.metricsAPI) | nindent 6 }} | |||
There was a problem hiding this comment.
Somehow the changes didn't work accordingly, and adding a line break at the end solved the problem
There was a problem hiding this comment.
I wasn't able to reproduce the issue. Can you provide more details? (I don't understand the comment about empty component label).
|
Hi @reyes256 , do you still want to take this one across the finish line? Is there anything I can help you with? |
|
@alpeb yes i would like to continue, i'll be working on it |
Signed-off-by: Fernando Reyes <[email protected]>
|
@alpeb Seems like 'nodeAffinity' has already been added in both tap and tap-injector components, however i'm not sure how to modify the dashboard component, its not in a separate file and i dont know if its directly on the values.yml |
There was a problem hiding this comment.
@alpeb Seems like 'nodeAffinity' has already been added in both tap and tap-injector components
They're calling the linkerd.affinity partial, but there's no tap.nodeAffinity nor tapInjector.nodeAffinity entries in values.yaml.
however i'm not sure how to modify the dashboard component, its not in a separate file and i dont know if its directly on the values.yml
It's the web.yaml template, that uses the dashboard entries from values.yaml
| @@ -71,9 +71,10 @@ spec: | |||
| {{- include "linkerd.tolerations" (dict "Values" .Values.metricsAPI) | nindent 6 }} | |||
| {{- end -}} | |||
| {{- include "linkerd.node-selector" (dict "Values" .Values.metricsAPI) | nindent 6 }} | |||
| {{- include "linkerd.affinity" (dict "Values" .Values.metricsAPI) | nindent 6 }} | |||
There was a problem hiding this comment.
I wasn't able to reproduce the issue. Can you provide more details? (I don't understand the comment about empty component label).
|
This PR appears to be stale, so closing for now. Please reopen a new one addressing the feedback above if you're still interested on implementing this. |
Add to Helm linkerd-viz and tracing deployment resources nodeAffinity labels
NodeAffinity was not enabled for Viz Deployments resources
Add to helm values and each of Viz Deployment the labels to add the affinity labels from the shared partials and
allow to be more granular on the manifest setup
cd viz/charts/linkerd-viz/
helm template .
Fixes #10680
Signed-off-by: Fernando Reyes [email protected]