linkerd-viz and linkerd-jaeger charts do not support nodeAffinity #10680
Labels
Comments
|
I would like to work on this, can you assign this to me or accept PR? |
|
Hi @jrsalgado! You don't need to be assigned in order to work on this. Looking forward to seeing a PR! Please reach out if you have any questions. |
|
@adleong here it is a PR to add linkerd-jeaguer charts nodeAffinity settings, will create a separate PR for linkerd-viz soon. |
|
Hi @adleong, here it is the viz nodeAffinity too |
|
Helloo @adleong, the PR about viz nodeAffinity is open again. |
naing2victor
added a commit
to naing2victor/linkerd2
that referenced
this issue
Oct 6, 2023
naing2victor
added a commit
to naing2victor/linkerd2
that referenced
this issue
Oct 6, 2023
Signed-off-by: Naing Naing Htun <[email protected]>
alpeb
pushed a commit
that referenced
this issue
Nov 17, 2023
Fixes #10680 Signed-off-by: Naing Naing Htun <[email protected]> Co-authored-by: Alex Leong <[email protected]>
Merged
hawkw
added a commit
that referenced
this issue
Nov 22, 2023
## edge-23.11.4 This edge release introduces support for the native sidecar containers entering beta support in Kubernetes 1.29. This improves the startup and shutdown ordering for the proxy relative to other containers, fixing the long-standing shutdown issue with injected `Job`s. Furthermore, traffic from other `initContainer`s can now be proxied by Linkerd. In addition, this edge release includes Helm chart improvements, and improvements to the multicluster extension. * Added a new `config.alpha.linkerd.io/proxy-enable-native-sidecar` annotation and `Proxy.NativeSidecar` Helm option that causes the proxy container to run as an init-container (thanks @teejaded!) (#11465; fixes #11461) * Fixed broken affinity rules for the multicluster `service-mirror` when running in HA mode (#11609; fixes #11603) * Added a new check to `linkerd check` that ensures all extension namespaces are configured properly (#11629; fixes #11509) * Updated the Prometheus Docker image used by the `linkerd-viz` extension to v2.48.0, resolving a number of CVEs in older Prometheus versions (#11633) * Added `nodeAffinity` to `deployment` templates in the `linkerd-viz` and `linkerd-jaeger` Helm charts (thanks @naing2victor!) (#11464; fixes #10680)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What is the issue?
In contrast to linkerd-control-plane helm chart
linkerd-vizandlinkerd-jaegerhelm charts do not support nodeAffinity at the moment. Can you please add this functionality there unless there is any specific reason not to do it?How can it be reproduced?
Deploy latest version of linkerd-viz and linkerd-jaeger
Logs, error output, etc
no errors
output of
linkerd check -o shortnot required
Environment
kubernetes 1.25.5
linkerd 2.12.4
Possible solution
update helm charts to add nodeAffinity
Additional context
No response
Would you like to work on fixing this bug?
None
The text was updated successfully, but these errors were encountered: