update builds and use release workflows #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
✅ Deploy Preview for lineup-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thinkh
requested changes
May 9, 2022
There was a problem hiding this comment.
I've tried the netlify demo and cannot confirm that the CodeSandbox export is working. The build errors described in #67 are gone, but the ranking does not show any data in Chrome 100 or Firefox 100.
Could you please have a look again, if there is something missing or has changed in LineUp?
Beside that the changes look good to me.
|
merging and opening a new PR for a potential fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prerequisites:
Summary
updates setup and dependencies . As part of it fixes #67