Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken export to CodeSandbox #67

Closed
thinkh opened this issue Dec 17, 2020 · 2 comments
Closed

Broken export to CodeSandbox #67

thinkh opened this issue Dec 17, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented Dec 17, 2020

  • Release number or git hash: 4.0.0
  • Web browser version and OS: Chrome 87

Steps to reproduce

  1. Open https://lineup.js.org/app_develop/#soccer
  2. Export to example to CodeSandbox.io

Observed behavior

Error 1

DependencyNotFoundError
Could not find dependency: 'tslib' relative to '/node_modules/lineupjs/src/provider/ADataProvider.js'

grafik

If I follow the instructions and import tslib, I get the following error.

Error 2

TypeError
Cannot read property 'FLOAT_ASC' of undefined

...

  1 | 
> 2 | import * as LineUpJS from "lineupjs";
  3 | import "lineupjs/build/LineUpJS.css";
  4 | import * as Papa from "papaparse";
  5 | 

grafik

Switching the dependency to LineUp v4.1.1 shows the same error.

grafik

Expected behavior

The export should work without errors and show the demo.

@thinkh thinkh added the bug Something isn't working label Dec 17, 2020
@sgratzl sgratzl self-assigned this Mar 10, 2021
@sgratzl
Copy link
Member

sgratzl commented May 13, 2021

the dev version of lineupjs (lineupjs@next) should have no problems anymore with circular imports

@dg-datavisyn
Copy link

I still have the issue with the version 4.2.0-alpha.1 which is labelled as next on npmjs.
See https://codesandbox.io/s/lineup-boiler-plate-pktp1?file=/package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants