Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default env with Env::default() #1237

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

totsteps
Copy link
Collaborator

Fixes #1181

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! have a few little suggestions but this looks like a good bit of cleanup. :)

druid/src/app.rs Outdated Show resolved Hide resolved
druid/src/core.rs Outdated Show resolved Hide resolved
druid/src/theme.rs Outdated Show resolved Hide resolved
@luleyleo luleyleo added the S-waiting-on-author waits for changes from the submitter label Sep 16, 2020
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@cmyr cmyr merged commit 67b52ff into linebender:master Sep 18, 2020
@totsteps totsteps deleted the env-setup branch September 18, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author waits for changes from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env setup is confusing
3 participants