env setup is confusing

[cmyr]

We have Env::default but the actual way to create the default env is theme::init. I think it probably should be Env::default, but maybe there's a method in theme that adds the theme items, and Env::default should just call this?

[totsteps]

Will give this a shot. I tried this:

// file env.rs
impl Default for Env {
    fn default() -> Self {
        ...
       let env = Env(Arc::new(inner))
            .adding(Env::DEBUG_PAINT, false)
            .adding(Env::DEBUG_WIDGET_ID, false)
            .adding(Env::DEBUG_WIDGET, false);

       crate::theme::init(env)
    }
}

// file theme.rs
pub fn init(env: Env) -> Env {
    env.adding(WINDOW_BACKGROUND_COLOR, Color::rgb8(0x29, 0x29, 0x29))
     ...
    .adding(
        UI_FONT,
        FontDescriptor::new(FontFamily::SYSTEM_UI).with_size(15.0),
    )
}

[cmyr]

I think this is a good solution!