Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Dask dependency to avoid dask-expr #387

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

wilsonbb
Copy link
Collaborator

As noted in #382, we currently do not support dask-expr as a backend, however it became the default Dask backend with the release of Dask 2024.3.0 (See dask/community#366)

Here we pin Dask to be in a range below this version until dask-expr support is fully added.

Additionally in the LSDB notebook, we update the cone_search call to use the new radius_arcsec argument (formerly just radius)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wilsonbb wilsonbb changed the title Remotes/origin/wilsonbb patch 3 Pin Dask dependency to avoid dask-expr Mar 14, 2024
Copy link

Before [f740b6f] <v0.3.4> After [801b9ea] Ratio Benchmark (Parameter)
59.1±7ms 47.4±0.5ms ~0.80 benchmarks.time_batch
49.5±0.7ms 51.0±1ms 1.03 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (f740b6f) to head (5ad5c21).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          25       25           
  Lines        1702     1702           
=======================================
  Hits         1626     1626           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wilsonbb wilsonbb requested a review from dougbrn March 14, 2024 16:27
@wilsonbb wilsonbb marked this pull request as ready for review March 14, 2024 16:29
@wilsonbb wilsonbb merged commit 41411e2 into main Mar 14, 2024
13 checks passed
@dougbrn dougbrn deleted the remotes/origin/wilsonbb-patch-3 branch April 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants