Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Dask dependency to avoid dask-expr #385

Closed
wants to merge 1 commit into from
Closed

Conversation

wilsonbb
Copy link
Collaborator

@wilsonbb wilsonbb commented Mar 14, 2024

As noted in #382, we currently do not support dask-expr as a backend, however it became the default Dask backend with the release of Dask 2024.3.0 (See dask/community#366)

Here we pin Dask to be in a range below this version until dask-expr support is fully added.

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

@wilsonbb wilsonbb requested a review from dougbrn March 14, 2024 15:52
Copy link

Before [f740b6f] <v0.3.4> After [bca6ae8] Ratio Benchmark (Parameter)
47.9±0.6ms 47.9±0.3ms 1 benchmarks.time_batch
50.0±0.1ms 50.3±0.9ms 1 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (f740b6f) to head (ead3bff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          25       25           
  Lines        1702     1702           
=======================================
  Hits         1626     1626           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Docs build issue looks tied to us falling out of date with LSDB

@wilsonbb wilsonbb closed this Mar 14, 2024
@wilsonbb
Copy link
Collaborator Author

Looks good! Docs build issue looks tied to us falling out of date with LSDB

Thanks! I ended up putting a fix for both in #387

@dougbrn dougbrn deleted the wilsonbb-patch-3 branch April 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants