Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch VSS, Expose build_with_vss* methods in bindings. #376

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Launch VSS, Expose build_with_vss* methods in bindings. #376

merged 2 commits into from
Oct 17, 2024

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Oct 15, 2024 •
edited
Loading

Based on #369

@G8XSU G8XSU changed the title Expose build_with_vss_store & build_with_vss_store_with_fixed_headers in bindings. Expose build_with_vss* methods in bindings. Oct 15, 2024
@G8XSU G8XSU requested a review from tnull October 15, 2024 07:20
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from fe89347 to 66bdf17 Compare October 15, 2024 18:53
@G8XSU G8XSU changed the title Expose build_with_vss* methods in bindings. Launch VSS, Expose build_with_vss* methods in bindings. Oct 15, 2024
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from 1f0a68a to 6afd993 Compare October 15, 2024 23:41
tnull
tnull reviewed Oct 16, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
src/builder.rs Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from 8c94253 to 3a9c604 Compare October 17, 2024 00:10
@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 17, 2024

CI will fail until rebased on top of #379

@G8XSU G8XSU requested a review from tnull October 17, 2024 00:16
@G8XSU G8XSU force-pushed the vss-bindings branch 2 times, most recently from 4fdddd3 to 368bf60 Compare October 17, 2024 05:27
@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 17, 2024

Rebased on top #379

tnull
tnull reviewed Oct 17, 2024
View reviewed changes
bindings/ldk_node.udl Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@tnull
Copy link
Collaborator

tnull commented Oct 17, 2024

Needs a rebase now that #369 landed.

@tnull tnull mentioned this pull request Oct 17, 2024
Open
12 tasks
@G8XSU G8XSU requested a review from tnull October 17, 2024 09:18
@tnull
Copy link
Collaborator

tnull commented Oct 17, 2024

Feel free to squash the fixup.

@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 17, 2024

Squashed.

tnull
tnull approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tnull tnull merged commit 651f837 into lightningdevkit:main Oct 17, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @tnull