Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable using VssStore with VssHeaderProvider. #369

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Enable using VssStore with VssHeaderProvider. #369

merged 3 commits into from
Oct 17, 2024

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Oct 10, 2024

  • Enable using VssStore with VssHeaderProvider.
  • Default to LnUrlJWT auth for using VSS.

tnull
tnull reviewed Oct 11, 2024
View reviewed changes
src/builder.rs Show resolved Hide resolved
src/builder.rs Show resolved Hide resolved
tnull
tnull reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on the formatting step.

@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 15, 2024

Pushed 2 more commits but its not showing up since github is still processing them since 3 hrs: https://github.blog/changelog/2023-09-26-more-details-provided-when-a-pull-request-is-merged-indirectly-or-is-still-processing-updates/#pushed-commits-are-still-being-processed.

@G8XSU G8XSU mentioned this pull request Oct 15, 2024
Merged
@tnull
Copy link
Collaborator

tnull commented Oct 15, 2024

Pushed 2 more commits but its not showing up since github is still processing them since 3 hrs: https://github.blog/changelog/2023-09-26-more-details-provided-when-a-pull-request-is-merged-indirectly-or-is-still-processing-updates/#pushed-commits-are-still-being-processed.

Hmm, could you force-push once more? Can't review commits that aren't there 😁

@tnull
Copy link
Collaborator

tnull commented Oct 15, 2024

Also needs a rebase to account for the yanked 0.0.124.

@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 15, 2024

Hmm, could you force-push once more? Can't review commits that aren't there 😁

Already force-pushed, didn't work. Hopefully it will be resolved after rebase, otherwise i might have to close this PR and open a new one.

@G8XSU G8XSU force-pushed the vss-lnauth branch 2 times, most recently from 87751f4 to d33d4ed Compare October 15, 2024 18:03
@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 15, 2024

Rebased.

@G8XSU G8XSU force-pushed the vss-lnauth branch 2 times, most recently from 422857c to d9c3f39 Compare October 15, 2024 18:48
@G8XSU G8XSU mentioned this pull request Oct 15, 2024
Merged
@G8XSU G8XSU requested a review from tnull October 15, 2024 22:56
tnull
tnull reviewed Oct 16, 2024
View reviewed changes
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/io/vss_store.rs Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
tests/integration_tests_vss.rs Outdated Show resolved Hide resolved
@tnull tnull mentioned this pull request Oct 16, 2024
Closed
@G8XSU G8XSU force-pushed the vss-lnauth branch 2 times, most recently from 06d0d2c to daa18b3 Compare October 16, 2024 23:55
@G8XSU G8XSU requested a review from tnull October 17, 2024 00:16
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
src/builder.rs Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
src/builder.rs Show resolved Hide resolved
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, mod #369 (comment)

Feel free to interleave and squash current round of fixups.

G8XSU added 3 commits October 17, 2024 01:07
@G8XSU
Enable using VssStore with VssHeaderProvider.
2646629
@G8XSU
Default to LnUrlJWT auth for using VSS.
ffea164 
build_with_vss_store now uses LNURL-Auth as the
default method for authentication/authorization.
@G8XSU
Add build_with_vss* methods for ArcedNodeBuilder.
cf91516
tnull
tnull approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull tnull merged commit 9ba95be into lightningdevkit:main Oct 17, 2024
6 of 13 checks passed
@tnull tnull mentioned this pull request Oct 17, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @tnull