-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce blank line between variable declaration and usage #15
Labels
Comments
wincent
referenced
this issue
in julien/liferay-portal
Apr 24, 2020
- Correct a bad description (says "doesn't throw" but supposed to be "throws"). - Replace the sample "broken input" with something that describes why it is broken (eg. "not a relative or absolute URL"). - Hard-code "http://localhost/" to explicitly confirm the invariant that `location.href` is always going to be a URL that ends with a trailing slash. - Add a blank line for consistency with style used elsewhere. At some point, this kind of thing will be autoformatted; see: https://github.com/liferay/eslint-config-liferay/issues/160
brianchandotcom
referenced
this issue
in brianchandotcom/liferay-portal
Apr 24, 2020
- Correct a bad description (says "doesn't throw" but supposed to be "throws"). - Replace the sample "broken input" with something that describes why it is broken (eg. "not a relative or absolute URL"). - Hard-code "http://localhost/" to explicitly confirm the invariant that `location.href` is always going to be a URL that ends with a trailing slash. - Add a blank line for consistency with style used elsewhere. At some point, this kind of thing will be autoformatted; see: https://github.com/liferay/eslint-config-liferay/issues/160
wincent
added a commit
that referenced
this issue
Dec 18, 2020
docs: word-smith some awkward phrasing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per request here.
Some (contrived) examples of correct code:
The text was updated successfully, but these errors were encountered: