LPS-110068 When asking explicitly for depot groups, never show the breadcrumb #86310

adolfopa · 2020-03-16T11:49:18Z

No description provided.

…eadcrumb

liferay-continuous-integration · 2020-03-16T11:49:24Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2020-03-16T11:53:08Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 30 seconds 743 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2f11b484a399edbf5a21a940855cba106174eab8

Sender Branch:

Branch Name: pr-1327
Branch GIT ID: ac578a26b8e70a3b52056f13d755d7c3dcfcf1f4

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-03-16T14:02:24Z

❌ ci:test:stable - 9 out of 10 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 2 hours 8 minutes 51 seconds 871 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2f11b484a399edbf5a21a940855cba106174eab8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 3838dac2ae9689eceb6374dee03b44cf836abfdb

ci:test:stable - 9 out of 10 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/1~~

9 Successful Jobs:

ci:test:relevant - 29 out of 32 jobs PASSED

3 Failed Jobs:

29 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/1
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #363268
  1. LocalFile.PortalSmokeUpgrade#ViewPortalSmokeArchive621021 - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #345424

     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:5241: 1 PMD violation(s) were found.
     [echo] 
     [echo] PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/users-admin/users-admin-test/src/testIntegration/java/com/liferay/users/admin/search/test/UserReindexerPerformanceOfLargeUserGroupInManySitesTest.java:246 > Do not call Assert#fail improperly. (PMD Rule: AssertFailJUnitRule)
     [echo] WARNING: pmd-jdk8 does not match existing test types (blade-samples,database-upgrade-client,functional,jsf,plugins,portal-startup,service-builder,tck,modules-integration,integration,modules-unit,modules-unit-project-templates,unit)
     [echo] WARNING: pmd-jdk8 does not match existing test types (blade-samples,database-upgrade-client,functional,jsf,plugins,portal-startup,service-builder,tck,modules-integration,integration,modules-unit,modules-unit-project-templates,unit)
     [echo] record.testray.results.start.timestamp: 03-16-2020 06:38:32:161 PDT
[stopwatch] [record.testray.results: 0.001 sec]
BUILD FAILED

/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:11509: The following error occurred while executing this line:

/opt/dev/projects/github/liferay-portal/build-test-batch.xml:5241: 1 PMD violation(s) were found.
PMD VIOLATION: /opt/dev/projects/github/liferay-portal/modules/apps/users-admin/users-admin-test/src/testIntegration/java/com/liferay/users/admin/search/test/UserReindexerPerformanceOfLargeUserGroupInManySitesTest.java:246 > Do not call Assert#fail improperly. (PMD Rule: AssertFailJUnitRule)
Total time: 7 minutes 22 seconds

Build step 'Execute shell' marked build as failure

Recording test results

[PostBuildScript] - Executing post build scripts.

define: [LabelParameterValue: NODE_NAME=cloud-10-0-10-82]

Triggering projects: verification-node

[liferay-jenkins-ee] $ /bin/bash -e -x /tmp/jenkins1197064118089068447.sh

echo 'Update the workspace repository for post-build steps.'

Update the workspace repository for post-build steps.
git clean -d -f -x

Removing .ssh/

Removing git/

Removing reset.repository.log

Removing start.properties

Removing test-results/
git reset --hard

HEAD is now at 45bbefd6cf LRCI-1089 SF
set +e
git show-ref --verify --quiet refs/heads/master-temp-1584365440928
VERIFY_BRANCH_RESULT=0
set -e
[[ 0 == 0 ]]
git checkout master-temp-1584365440928

Already on 'master-temp-1584365440928'
git log -n 1

commit 45bbefd6cf11278be82ef904bbe5d20d3efa7391

For upstream results, click here.

brianchandotcom · 2020-03-16T16:14:26Z

@inacionery please fix https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/363268/AXIS_VARIABLE=0,label_exp=!master/testReport/junit/com.liferay.poshi.runner/PoshiRunner/test_LocalFile_PortalSmokeUpgrade_ViewPortalSmokeArchive621021_/

LIFERAY_ERROR: Unable to initialize My Account panel permissions for portlet com_liferay_portal_workflow_web_internal_portlet_UserWorkflowPortlet in company 10155


	at com.liferay.poshi.runner.selenium.LiferaySeleniumHelper.assertNoPoshiWarnings(LiferaySeleniumHelper.java:298)
	at com.liferay.poshi.runner.PoshiRunner.test(PoshiRunner.java:182)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)

brianchandotcom · 2020-03-16T16:15:26Z

Merged. Thank you.
View total diff: f6daa00...2731cb9

brianchandotcom · 2020-03-16T16:16:16Z

@hhuijser can you talk to @wincent about enforcing 2731cb9

Since you already have the algorithm for Java.

In short, if you declare a var, add a line break before using it. This shows order of requirements better.

wincent · 2020-03-16T16:32:03Z

I created https://github.com/liferay/eslint-config-liferay/issues/160 to track enforcement of this. If there are any nuances to this @hhuijser can you please comment there? I think should be possible to enforce using ESLint in way that conflicts with neither Prettier nor other ESLint rules.

inacionery · 2020-03-16T17:11:41Z

Hey @brianchandotcom, this error is a race condition, maybe @shuyangzhou can help us with that?

hhuijser · 2020-03-17T14:50:55Z

@wincent the logic in SF is all sitting here: https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/java/com/liferay/source/formatter/checkstyle/checks/MissingEmptyLineCheck.java

It's not super straight forward reading that, since it's a checkstyle check

wincent · 2020-03-17T15:19:55Z

Thanks @hhuijser. I took a quick look at it and have made a note of it so that I can refer to it — I'll let you know if I have any questions.

AliciaGarciaGarcia and others added 3 commits March 16, 2020 09:31

LPS-110068 let membership show breadcrumb or not

265f571

LPS-110068 avoid asset libraries duplication on list

ed591da

LPS-110068 When asking explicitly for depot groups, never show the br…

ac578a2

…eadcrumb

adolfopa mentioned this pull request Mar 16, 2020

LPS-110068 avoid asset libraries duplication on list adolfopa/liferay-portal#1327

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Mar 16, 2020

liferay-continuous-integration added ci:test:stable - pending ci:test:stable - failure and removed ci:test:stable - pending labels Mar 16, 2020

brianchandotcom closed this Mar 16, 2020

wincent mentioned this pull request Sep 24, 2020

Enforce blank line between variable declaration and usage liferay/liferay-frontend-projects#15

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-110068 When asking explicitly for depot groups, never show the breadcrumb #86310

LPS-110068 When asking explicitly for depot groups, never show the breadcrumb #86310

adolfopa commented Mar 16, 2020

liferay-continuous-integration commented Mar 16, 2020

liferay-continuous-integration commented Mar 16, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 16, 2020

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8

Job Results:

For upstream results, click here.

brianchandotcom commented Mar 16, 2020

brianchandotcom commented Mar 16, 2020

brianchandotcom commented Mar 16, 2020

wincent commented Mar 16, 2020 •

edited

Loading

inacionery commented Mar 16, 2020

hhuijser commented Mar 17, 2020

wincent commented Mar 17, 2020

LPS-110068 When asking explicitly for depot groups, never show the breadcrumb #86310

LPS-110068 When asking explicitly for depot groups, never show the breadcrumb #86310

Conversation

adolfopa commented Mar 16, 2020

liferay-continuous-integration commented Mar 16, 2020

liferay-continuous-integration commented Mar 16, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 30 seconds 743 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Mar 16, 2020

❌ ci:test:stable - 9 out of 10 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 2 hours 8 minutes 51 seconds 871 ms

Base Branch:

Copied in Private Modules Branch:

1 Failed Jobs:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8

Job Results:

For upstream results, click here.

brianchandotcom commented Mar 16, 2020

brianchandotcom commented Mar 16, 2020

brianchandotcom commented Mar 16, 2020

wincent commented Mar 16, 2020 • edited Loading

inacionery commented Mar 16, 2020

hhuijser commented Mar 17, 2020

wincent commented Mar 17, 2020

wincent commented Mar 16, 2020 •

edited

Loading