feat: support changing input method in settings (tap+drag, tag, drag) #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-anders
force-pushed
the
input_method
branch
2 times, most recently
from
8c95b48 to
8474c81
Compare
|
Video of the feature in action: (not sure how I can get the emulator to record the mouse as well, but I think the video still gets its point across) piece_shift_method.webm |
veloce
reviewed
Jul 18, 2024
| // This is called 'Either' in the Web UI, but in the app we might display this string | ||
| // without having the other values as context, so we need to be more explicit. | ||
| // TODO add this to mobile translations | ||
| PieceShiftMethod.either => 'Click or drag pieces', |
There was a problem hiding this comment.
👍
Either is too vague I agree. But a short 'Tap or drag' should be enough.
veloce
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #855
Needs lichess-org/flutter-chessground#39