Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support input method (click, drag, either) #39

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

tom-anders
Copy link
Contributor

This would be required for implementing lichess-org/mobile#855

@tom-anders
Copy link
Contributor Author

I added two new unit tests, and also added a button to the example app. Everything seems to work fine (including premoves), but feel free to play around, hopefully I didn't miss anything

@tom-anders
Copy link
Contributor Author

(Moved inputMethod to BoardSettings, change click to tap

example/lib/main.dart Outdated Show resolved Hide resolved
lib/src/board_settings.dart Outdated Show resolved Hide resolved
lib/src/widgets/board.dart Outdated Show resolved Hide resolved
lib/src/widgets/board.dart Outdated Show resolved Hide resolved
test/widgets/board_test.dart Outdated Show resolved Hide resolved
test/widgets/board_test.dart Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/board_settings.dart Outdated Show resolved Hide resolved
lib/src/board_settings.dart Show resolved Hide resolved
lib/src/board_settings.dart Outdated Show resolved Hide resolved
test/widgets/board_test.dart Show resolved Hide resolved
test/widgets/board_test.dart Show resolved Hide resolved
@tom-anders
Copy link
Contributor Author

Addressed all your comments, thanks again for reviewing!

Copy link
Collaborator

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@veloce veloce merged commit 382549f into lichess-org:main Jul 16, 2024
1 check passed
@tom-anders tom-anders deleted the inputMethod branch July 16, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants