Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab animation not played #1270

Closed
wants to merge 1 commit into from
Closed

Fix tab animation not played #1270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions lib/src/widgets/pgn.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,20 @@ class _DebouncedPgnTreeViewState extends ConsumerState<DebouncedPgnTreeView> {
super.initState();
pathToCurrentMove = widget.currentPath;
pathToBroadcastLiveMove = widget.broadcastLivePath;
WidgetsBinding.instance.addPostFrameCallback((_) {
if (currentMoveKey.currentContext != null) {
Scrollable.ensureVisible(
currentMoveKey.currentContext!,
alignment: 0.5,
alignmentPolicy: ScrollPositionAlignmentPolicy.keepVisibleAtEnd,
);
}
});

// TODO The scroll conflicts with the tab animation and skips it
// so it is commented until a solution is found to keep both the
// tab animation and the automatic scroll to the current move
//
// WidgetsBinding.instance.addPostFrameCallback((_) {
// if (currentMoveKey.currentContext != null) {
// Scrollable.ensureVisible(
// currentMoveKey.currentContext!,
// alignment: 0.5,
// alignmentPolicy: ScrollPositionAlignmentPolicy.keepVisibleAtEnd,
// );
// }
// });
}

@override
Expand Down
Loading