Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab animation not played #1270

Closed
wants to merge 1 commit into from

Conversation

julien4215
Copy link
Contributor

Fix #1232 but creates a new issue

I suggest to remove the automatic scroll to the current move in the analysis screen until a better solution is found.

@veloce
Copy link
Contributor

veloce commented Dec 18, 2024

Well the automatic scroll is more important than the tab animation not working, isn't it?

So this fix is not acceptable. But thanks for finding the issue. There is maybe another way to solve it. Like delay the automatic scroll so it happens after the animation perhaps?

@julien4215
Copy link
Contributor Author

Now that I think about it automatic scroll might be more important.

I don't think delaying the automatic scroll will make things better because the tab animation takes quite a long time to finish (you can see it with the app indicator changing 1 or 2 seconds after having swiped).

The only easy solution I can see is to set the scroll at the bottom but I don't know if a game is always opened on the last move.

@veloce veloce closed this in b75cd58 Dec 18, 2024
@veloce
Copy link
Contributor

veloce commented Dec 18, 2024

Tested with a delay of 500ms it works pretty well. And the delay is not really disturbing imo.

@julien4215 julien4215 deleted the tab-animation-fix branch December 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swiping away from the Opening Explorer Tab leads to visual bug
2 participants