darwin: workaround apple pthread_cond_wait bug #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
reviewed
Oct 12, 2023
vbfox
force-pushed
the
macos_uv_cond_wait_ebusy
branch
from
1f45d1c to
561461b
Compare
Under heavy workloads pthread_cond_wait on macOS can return EINVAL while all the input parameters are correct. As it happens due to a syscall having an errno of EBUSY we can detect it and workaround it. Fixes libuv#4165
vbfox
force-pushed
the
macos_uv_cond_wait_ebusy
branch
from
561461b to
63092ca
Compare
|
Pushed a new version with style changes, opening the PR as it has been deployed in our production for a few days and is stable. |
bnoordhuis
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under heavy workloads
pthread_cond_waiton macOS can returnEINVALwhile all the input parameters are correct.As it happens due to a syscall having an
errnoofEBUSYwe can detect it and workaround it.Fixes #4165