Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 20.11.1 doesn't contain libuv 1.48 #51969

Closed
vbfox opened this issue Mar 5, 2024 · 2 comments
Closed

Node 20.11.1 doesn't contain libuv 1.48 #51969

vbfox opened this issue Mar 5, 2024 · 2 comments

Comments

@vbfox
Copy link

vbfox commented Mar 5, 2024

Version

v20.11.1

Platform

Darwin TRI-LVH4VV0Q52 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:31:00 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6020 arm64

Subsystem

No response

What steps will reproduce the bug?

Looking at the release notes of Node 20.11.1 specifies that libuv 1.48 is included.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

If libuv 1.48 was included I would expect a fix for a MacOs crash that I made to be included as it was released in libuv 1.47.

What do you see instead?

The crash happens in NodeJs 20.11.1 and the code in /deps/uv seem to be from libuv 1.46

Additional information

No response

@marco-ippolito
Copy link
Member

marco-ippolito commented Mar 5, 2024

You are correct indeed, 20.11.1 does not update libuv version to 1.48.0 but only floats a security patch. It will be probably updated in the next minor.
It is an imprecision in the changelog.
Node 21.6.2 ships libuv 1.48.0
Closing, feel free to reopen if you have more questions.

@richardlau
Copy link
Member

The changelog is incorrect, as @marco-ippolito says we didn't update libuv in the most recent Node.js 20.11.1 security release.

We can't upgrade to libuv versions 1.47.0 and later in Node.js 20 because upstream libuv have dropped support for macOS <11 and we target macOS 10.15 for Node.js 20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants