Add tests for Gabow, WordGraph and Paths
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTWhyte
force-pushed
the
refactor-todd-coxeter-10-apr
branch
from
c41d583 to
7667ee2
Compare
|
I've updated the tests, deleting some stuff that isn't used. There are a couple of things I've noticed that I'll ask about when convenient, e.g. about how to 'unset' the 'source' node in the |
MTWhyte
force-pushed
the
refactor-todd-coxeter-10-apr
branch
from
7667ee2 to
16a5434
Compare
MTWhyte
force-pushed
the
refactor-todd-coxeter-10-apr
branch
from
16a5434 to
8e89960
Compare
Closed
added 3 commits
April 12, 2024 17:21
| @@ -32,7 +32,6 @@ def test_001(): | |||
| w.set_target(i, i % 2, i + 1) | |||
|
|
|||
| p = Paths(w) | |||
| assert p.at_end() | |||
There was a problem hiding this comment.
Just to say that I think this is a bug in libsemigroups, that the return value of at_end() is non-deterministic if the Paths object isn't properly initialised (it somehow isn't tracked in the class whether or not it is initialised, but it is implicitly assumed that it is).
|
Am I ok to merge this @MTWhyte ? |
|
Yeah go ahead!
On 17 Apr 2024, at 16:28, James Mitchell ***@***.***> wrote:
Am I ok to merge this @MTWhyte<https://github.com/MTWhyte> ?
—
Reply to this email directly, view it on GitHub<#147 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKEUEZOF7EIA7UWUIBRJPSDY52ILDAVCNFSM6AAAAABGAWC4SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGU2TEOJUG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests for the mentioned stuff, which seemed to get lost in some earlier merging.