Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some intermediate work #146

Closed
wants to merge 1 commit into from

Conversation

MTWhyte
Copy link
Contributor

@MTWhyte MTWhyte commented Apr 10, 2024

This is some work in progress from my branch of libsemigroups_pybind11 which was changing the bindings to accommodate what I think we originally called the 'Todd-Coxeter refactor' changes to libsemigroups.

This is a PR to the wrong base: this is deliberate in the sense that I won't have time to do the rebase this morning, but hopefully can still avoid the duplication of work since it'll at least be visible what files I've been at here.

@MTWhyte MTWhyte marked this pull request as draft April 10, 2024 09:04
@james-d-mitchell james-d-mitchell changed the base branch from main to v1 April 10, 2024 09:50
@MTWhyte MTWhyte force-pushed the refactor-todd-coxeter branch from ba75e12 to e57b09d Compare April 10, 2024 15:02
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't need to be changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved to src/old

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved to src/old

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved to src/old

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved to src/old

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved to src/old

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was moved to src/old

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't need to be changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This files doesn't need to be changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't need to be changed

@MTWhyte
Copy link
Contributor Author

MTWhyte commented Apr 12, 2024

Superseded by #147

@MTWhyte MTWhyte closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants