Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Autocomplete to use createRoot #512

Closed
wants to merge 1 commit into from
Closed

Upgrade Autocomplete to use createRoot #512

wants to merge 1 commit into from

Conversation

chartgerink
Copy link
Member

This PR upgrades the Autocomplete component to use createRoot as is necessary for utilizing React 18. Fixes #364. It ended up being documented by Algolia too.

Please note that I changed the file from .tsx to .jsx - there were some Typescript errors I did not know how to work around at this point:

Property 'unmount' does not exist on type 'never'.

So if anyone knows their Typescript and can help work around this - I would love your help!

Note: Does not fix #326 - makes it seem a tiny bit less of an issue though?

@chartgerink chartgerink added the bug Something isn't working label Jul 15, 2022
@chartgerink chartgerink added this to the July 2022 milestone Jul 15, 2022
@chartgerink chartgerink requested a review from nsunami July 15, 2022 12:46
@chartgerink chartgerink marked this pull request as ready for review July 15, 2022 12:46
@chartgerink chartgerink temporarily deployed to researchequa-fix-364-fvgyrkpdl July 15, 2022 12:46 Inactive
@chartgerink
Copy link
Member Author

Noticing one issue with the search results not disappearing...

Screen.Recording.2022-07-15.at.15.04.53.mov

@nsunami nsunami temporarily deployed to researchequa-fix-364-dcoafbzxe July 26, 2022 01:07 Inactive
@nsunami
Copy link
Collaborator

nsunami commented Jul 26, 2022

@chartgerink Is it ok to let go and merge this bug to the main? Or, should we fix this before merging?

Noticing one issue with the search results not disappearing...

Screen.Recording.2022-07-15.at.15.04.53.mov

I also reproduced this issue on my end. It seems like blurring does not work consistently. (Sometimes it does—especially when we focus out from the window and back.)

@chartgerink
Copy link
Member Author

I think this is quite the usability issue so I'd rather not merge to be honest and keep the warning.

We could fix this but I'm also not sure where to start. Seems like all of this (plus the blurring issue) is starting to make me wonder whether the Algolia implementation is the best route here.

@chartgerink chartgerink temporarily deployed to researchequa-fix-364-1zjwokr6s July 29, 2022 10:03 Inactive
@chartgerink chartgerink added the wontfix This will not be worked on label Jul 29, 2022
@chartgerink
Copy link
Member Author

Closing this as a wontfix for now. If we ever need to come back to it we can...

@chartgerink chartgerink deleted the fix/364 branch February 10, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React.renderwarning in Autocomplete.tsx Auto-unfocusing/blurring from the reference text input
2 participants