Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.renderwarning in Autocomplete.tsx #364

Closed
chartgerink opened this issue Mar 31, 2022 · 4 comments · Fixed by #784
Closed

React.renderwarning in Autocomplete.tsx #364

chartgerink opened this issue Mar 31, 2022 · 4 comments · Fixed by #784
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chartgerink
Copy link
Member

As mentioned here, the Autocomplete component uses the render method, which has been updated in React@18.

The warning does not break anything at this point, but does prevent utilizing the full capacity of React@18. It would be helpful to resolve this warning before it becomes a breaking issue.

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. 
Until you switch to the new API, your app will behave as if it's running React 17. 
Learn more: https://reactjs.org/link/switch-to-createroot

Link to React docs on this. This seems to be relatively minor but my attempts didn't succeed 🥎 If you know how to fix this, we welcome a PR!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Jun 8, 2022
@chartgerink chartgerink added the good first issue Good for newcomers label Jul 1, 2022
@github-actions github-actions bot removed the Stale label Jul 28, 2022
@chartgerink chartgerink added the wontfix This will not be worked on label Jul 29, 2022
@chartgerink
Copy link
Member Author

Closing this as a wontfix. We can revisit it if it is important again for whatever reason.

@nsunami
Copy link
Collaborator

nsunami commented Aug 8, 2022

I found this and wanted to comment here in case we pick it up again in the future.
(Also closing this as not planned, not completed)
algolia/autocomplete#969

@nsunami
Copy link
Collaborator

nsunami commented Oct 4, 2022

I'm re-opening this because I think we can fix this now! (I hope I'm not jinxing 😆)

@nsunami nsunami reopened this Oct 4, 2022
@nsunami nsunami removed the wontfix This will not be worked on label Oct 4, 2022
@nsunami nsunami self-assigned this Oct 4, 2022
@nsunami nsunami linked a pull request Oct 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
2 participants