Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for external data. #774

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fixes for external data. #774

merged 2 commits into from
Oct 20, 2021

Conversation

olovy
Copy link
Contributor

@olovy olovy commented Oct 14, 2021

  • Make it possible to show data from Record / meta in top of card (categorization)
  • Show inDataset in top of card
  • Fix color for link-count border
  • Make PlaceholderRecord and CacheRecord non-editable. But deletable for now
    • (should be data/vocab driven...?).

Checklist:

  • I have run the unit tests. yarn test:unit
  • I have run the linter. yarn lint

Tickets involved

LXL-2483

@olovy
Copy link
Contributor Author

olovy commented Oct 14, 2021

See also libris/librisxl/pull/1009

@oBlissing
Copy link
Contributor

oBlissing commented Oct 20, 2021

I will add a small change this PR after we have merged /pull/775

olovy and others added 2 commits October 20, 2021 16:46
* Make it possible to show data from Record / meta in top of card
(categorization)
* Show inDataset in top of card
* Fix color for link-count border
* Make PlaceholderRecord and CacheRecord non-editable (should be
data/vocab
driven...?). But deletable for now
@olovy olovy force-pushed the feature/lxl-2483-external-data branch from bb0024f to 1b34fae Compare October 20, 2021 14:47
@oBlissing
Copy link
Contributor

Lets merge :)

@olovy olovy merged commit dd553c3 into develop Oct 20, 2021
@olovy olovy deleted the feature/lxl-2483-external-data branch October 20, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants