-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic mechanisms for using/caching external entities #1009
Draft
olovy
wants to merge
47
commits into
develop
Choose a base branch
from
feature/lxl-2483-external-data
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olovy
requested review from
jannistsiroyannis
and removed request for
jannistsiroyannis
October 14, 2021 12:06
olovy
requested review from
andersju,
niklasl,
jannistsiroyannis,
kwahlin,
lrosenstrom,
klngwll and
oBlissing
and removed request for
niklasl
October 14, 2021 13:21
2 tasks
At the moment we have 30 243 811 links to 192 330 entities that would become placeholders. including |
olovy
force-pushed
the
feature/lxl-2483-external-data
branch
5 times, most recently
from
October 29, 2021 16:24
5135d6a
to
f898f7f
Compare
olovy
force-pushed
the
feature/lxl-2483-external-data
branch
from
November 25, 2021 10:39
86bacf8
to
cd16448
Compare
olovy
force-pushed
the
feature/lxl-2483-external-data
branch
from
January 20, 2022 19:19
2ff3472
to
d4de301
Compare
Rebase on develop |
olovy
force-pushed
the
feature/lxl-2483-external-data
branch
from
April 11, 2023 12:28
d4de301
to
301bb68
Compare
Rebase on develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache external entities in lddb as entities mapped to the local vocabulary (KBV in our case).
Store them with original/external id as thing id (similar to id.kb.se things) and with the new record type
CacheRecord
.Cache records are created automatically when any document is saved with a new link to something that can be understood/mapped by the system.
Only store cache records for things that are used (linked) directly from our data. So that they can be searched/linked like any other record. Links to other external things inside cache records are not stored in the system but converted on the fly in embellish (we don't want to pull in the whole of Wikidata recursively by mistake).
Create a
PlaceholderRecord
for all links in the system that point to something that is not in the system. For keeping track of links that point at something outside lddb that we don't have a cached entity for. e.g. things we can't map, things that don't exist, links from cache records. So that everything is kept up to date when data is added in different order (lddb__dependencies
etc.).isPartOf
)Mapping is a black box (URI -> KBV entity) that now contains hand-crafted code, later TVM or a mix of approaches
Add basic mapping for Wikidata places and persons
TODO
ExternalEntities get(Collection<String> iris)
Depends on libris/definitions/pull/324