Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topConcept from KBV ontology #353

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove topConcept from KBV ontology #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions source/vocab/base.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
rdfs:comment "Detta vokabulär fungerar som en central mappning till publika, välkända egenskaper och klasser."@sv;
rdfs:comment "This vocabulary serves as a central mapping to public, well-known properties and classes."@en;
dc:license <http://creativecommons.org/publicdomain/zero/1.0/> ;
owl:imports dc:, dctype:, skos:, prov:, foaf:, bibo:, sdo:, bf2:, bflc: ;
skos:hasTopConcept :Instance, :Work, :Item, :Agent, :IndexTerm .
owl:imports dc:, dctype:, skos:, prov:, foaf:, bibo:, sdo:, bf2:, bflc: .

# Various sources beyond the linked defintions themselves:

Expand Down
8 changes: 0 additions & 8 deletions source/vocab/things.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@
@prefix marc: <https://id.kb.se/marc/> .


# TODO: List top concepts to provide interfaces with:
# - a set of starting points for e.g. navigation, creation
# - a "roof" when finding base classes
#: skos:hasTopConcept :Work .
#: skos:hasTopConcept :Instance .
##: skos:hasTopConcept :Print .


Comment on lines -31 to -38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything hardcoded in the cataloguing client which would benefit from anything like this though? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oBlissing ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no references at all to hasTopConcept in the UI code.

Copy link
Contributor

@oBlissing oBlissing Dec 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I understand the question? We do have some similar things hardcoded:

https://github.com/libris/lxlviewer/blob/develop/lxljs/vocab.js#L169-L191

These things should probably be defined in the vocab instead, yes.

Copy link
Contributor Author

@klngwll klngwll Dec 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oBlissing Yeah the idea was if there was any function in for example viewer that would need something like that, we are still a bit unsure how this would translate to different contexts especially for Concept.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we discover more than one context, we could define different skos:Collections instead, listing classes of interest (for the then presumably documented contexts).

##
# Creative Works

Expand Down