-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove topConcept from KBV ontology #353
base: develop
Are you sure you want to change the base?
Conversation
# TODO: List top concepts to provide interfaces with: | ||
# - a set of starting points for e.g. navigation, creation | ||
# - a "roof" when finding base classes | ||
#: skos:hasTopConcept :Work . | ||
#: skos:hasTopConcept :Instance . | ||
##: skos:hasTopConcept :Print . | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything hardcoded in the cataloguing client which would benefit from anything like this though? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no references at all to hasTopConcept
in the UI code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I understand the question? We do have some similar things hardcoded:
https://github.com/libris/lxlviewer/blob/develop/lxljs/vocab.js#L169-L191
These things should probably be defined in the vocab instead, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oBlissing Yeah the idea was if there was any function in for example viewer that would need something like that, we are still a bit unsure how this would translate to different contexts especially for Concept
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we discover more than one context, we could define different skos:Collection
s instead, listing classes of interest (for the then presumably documented contexts).
Remove
skos:hasTopConcept
from KBV ontology.