-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: re-enable doc-check for Typescript snippets #2250
Merged
achingbrain
merged 15 commits into
libp2p:main
from
maschad:docs/update-getting-started
Jan 31, 2024
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
82c55cc
chore: re-enable doc-check
maschad c038e49
docs: update TS snippets for metrics
maschad 5c3fd7c
Merge branch 'main' into docs/update-getting-started
maschad 13ecbe4
Merge branch 'main' into docs/update-getting-started
achingbrain 420ab47
Merge branch 'main' into docs/update-getting-started
maschad fc21c52
Merge branch 'main' into docs/update-getting-started
achingbrain 70941f5
chore: move generic metrics docs to metrics interface
achingbrain de72f20
ci: re-enable doc-check
maschad 2e3255e
Merge branch 'main' into docs/update-getting-started
maschad e103a9c
Merge branch 'main' into docs/update-getting-started
maschad 57a25ad
Merge branch 'main' into docs/update-getting-started
maschad 0a5ea9f
Merge branch 'main' into docs/update-getting-started
maschad 1500a49
Merge branch 'main' into docs/update-getting-started
maschad 2a97f90
deps: reverted unnecessary typescript dep
maschad 39f23b7
Merge branch 'main' into docs/update-getting-started
maschad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
"sourceType": "module" | ||
} | ||
}, | ||
"exports": {}, | ||
"scripts": { | ||
"doc-check": "aegir doc-check" | ||
}, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hack for now given that typescript docs verifier relies on the exports for its check