-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: re-enable doc-check for Typescript snippets #2250
chore: re-enable doc-check for Typescript snippets #2250
Conversation
@@ -19,6 +19,7 @@ | |||
"sourceType": "module" | |||
} | |||
}, | |||
"exports": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hack for now given that typescript docs verifier relies on the exports for its check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some good doc improvements in here so I'd like to merge this but where is the bit of the PR that re-enables doc-check for TypeScript snippets like the title says?
Strange, I had assumed CI was running the command and that the actual It also turns out a recent typescript upgrade broke ts-node which |
33ba221
to
b17670d
Compare
242fd96
to
bca8d6e
Compare
1e73c3e
to
2e3255e
Compare
Title
chore: enable typescript docs verification for example snippets
Description
This had been disabled leading to some erroneous Typescript snippets in the examples
Notes & open questions
Change checklist