Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circuit Relay v2 follow up work items #1608

Closed
4 tasks done
p-shahi opened this issue Mar 2, 2023 · 0 comments · Fixed by #1619
Closed
4 tasks done

Circuit Relay v2 follow up work items #1608

p-shahi opened this issue Mar 2, 2023 · 0 comments · Fixed by #1619
Assignees
@achingbrain

Comments

@p-shahi
Copy link
Member

p-shahi commented Mar 2, 2023 •
edited by maschad
Loading 

          I am going to merge this which will publish an RC to unblock other efforts as it is functional though it still needs some work in a follow-up before being released.

Originally posted by @achingbrain in #1533 (review)

Tasks
Beta Give feedback
@p-shahi p-shahi mentioned this issue Mar 4, 2023
Closed
@BigLep BigLep added this to js-libp2p Mar 6, 2023
@BigLep BigLep moved this to 🏃‍♀️In Progress in js-libp2p Mar 6, 2023
achingbrain added a commit that referenced this issue Mar 8, 2023
@achingbrain
fix: circuit relay v2 follow up items
4204a07 
Code sanitation:

- splits code and config into transport and server
- updates docs
- consolidates relay and circuit tests
- updates relay discovery to use topology
- increases test coverage

Bug fixes:

- if multiple relays are discovered simultaneously, try to reserve a slot in them in series, otherwise we can end up listening on multiple relays by accident
- relay server tags the reserving peer instead of tagging itself
- incoming remote address was missing `p2p-circuit` tuple so we were allowing relay to relay forwarding
- relay client tags outgoing relay connections

fixes: #1608
refs: #1610
@achingbrain achingbrain mentioned this issue Mar 8, 2023
Merged
achingbrain added a commit that referenced this issue Mar 9, 2023
@achingbrain
fix: circuit relay v2 follow up items
5d36dec 
Code sanitation:

- splits code and config into transport and server
- updates docs
- consolidates relay and circuit tests
- updates relay discovery to use topology
- increases test coverage

Bug fixes:

- if multiple relays are discovered simultaneously, try to reserve a slot in them in series, otherwise we can end up listening on multiple relays by accident
- relay server tags the reserving peer instead of tagging itself
- incoming remote address was missing `p2p-circuit` tuple so we were allowing relay to relay forwarding
- relay client tags outgoing relay connections

fixes: #1608
refs: #1610
@p-shahi p-shahi mentioned this issue Mar 10, 2023
Merged
achingbrain added a commit that referenced this issue Mar 14, 2023
@achingbrain
fix: circuit relay v2 follow up items (#1619)
b085562 
Code sanitation:

- splits code and config into transport and server
- updates docs
- consolidates relay and circuit tests
- updates relay discovery to use topology
- increases test coverage
- reuses connection gater for acl instead of introducing a new acl mechanism
- adds migration guide

Bug fixes:

- if multiple relays are discovered simultaneously, try to reserve a slot in them in series, otherwise we can end up listening on multiple relays by accident
- relay server tags the reserving peer instead of tagging itself
- incoming remote address was missing `p2p-circuit` tuple so we were allowing relay to relay forwarding
- relay client tags outgoing relay connections
- limit data transfer as total in both directions instead of apply limit to both sides of the relayed stream separately
- allow client to refuse incoming relayed connections

fixes: #1608
refs: #1610
@github-project-automation github-project-automation bot moved this from 🏃‍♀️In Progress to 🎉Done in js-libp2p Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achingbrain achingbrain

Labels
None yet
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: circuit relay v2 follow up items libp2p/js-libp2p
2 participants
@achingbrain @p-shahi