Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Updating CI files #15

Merged
merged 1 commit into from
Dec 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
sudo: false
language: node_js

Expand All @@ -13,12 +14,15 @@ matrix:
script:
- npm run lint
- npm run test
- make test
- npm run coverage

before_script:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start

after_success:
- npm run coverage-publish

addons:
firefox: 'latest'
apt:
Expand Down
25 changes: 14 additions & 11 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,26 +1,29 @@
# Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
version: "{build}"

environment:
matrix:
- nodejs_version: "6"
- nodejs_version: "8"

init:
- git config --global core.autocrlf input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to prevent git from changing LF to CRLF. See ipfs/js-ipfs-repo#153 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is needed everywhere and https://github.com/ipfs/ci-sync/blob/master/configs/appveyor.yml should be updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victorbjelkholm Did some reading on appveyor. By default core.autocrlf is set to input.

matrix:
fast_finish: true

# cache:
# - node_modules
install:
# Install Node.js
- ps: Install-Product node $env:nodejs_version

platform:
- x64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent test on x32. ipfs/js-ipfs#1127 can be closed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to test on x32? I'm unsure if the 32 build is missing in dist.ipfs.io on purpose or if it was just skipped temporary. @whyrusleeping ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, read the patch wrongly. This is removing x64, which means appveyor could use a x32 processor, which go-ipfs is not shipping.

# Upgrade npm
- npm install -g npm

install:
- ps: Install-Product node $env:nodejs_version $env:platform
# Output our current versions for debugging
- node --version
- npm --version

# Install our package dependencies
- npm install

test_script:
- npm test
- npm run test:node

build: off

version: "{build}"
2 changes: 2 additions & 0 deletions ci/Jenkinsfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
javascript()
5 changes: 1 addition & 4 deletions circle.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
# Warning: This file is automatically synced from https://github.com/ipfs/ci-sync so if you want to change it, please change it there and ask someone to sync all repositories.
machine:
node:
version: stable

test:
post:
- npm run coverage -- --upload

dependencies:
pre:
- google-chrome --version
Expand Down