Updating CI files #15
Conversation
This commit updates all CI scripts to the latest version
| environment: | ||
| matrix: | ||
| - nodejs_version: "6" | ||
| - nodejs_version: "8" | ||
|
|
||
| init: | ||
| - git config --global core.autocrlf input |
There was a problem hiding this comment.
This is needed to prevent git from changing LF to CRLF. See ipfs/js-ipfs-repo#153 (comment)
There was a problem hiding this comment.
So this is needed everywhere and https://github.com/ipfs/ci-sync/blob/master/configs/appveyor.yml should be updated
There was a problem hiding this comment.
@victorbjelkholm Did some reading on appveyor. By default core.autocrlf is set to input.
|
|
||
| platform: | ||
| - x64 |
There was a problem hiding this comment.
This will prevent test on x32. ipfs/js-ipfs#1127 can be closed
There was a problem hiding this comment.
We don't want to test on x32? I'm unsure if the 32 build is missing in dist.ipfs.io on purpose or if it was just skipped temporary. @whyrusleeping ?
There was a problem hiding this comment.
Sorry, read the patch wrongly. This is removing x64, which means appveyor could use a x32 processor, which go-ipfs is not shipping.
|
Jenkins CI is failing on macos (see https://ci.ipfs.team/blue/organizations/jenkins/libp2p%2Fjs-libp2p-keychain/detail/automatic-ci-script-update/3/pipeline). I suspect its an issue with @diasdavid Should I write test and raise an issue? |
This commit updates all CI scripts to the latest version
Curiously enough, the appveyor file here has bunch of changes. @richardschneider can you confirm if those changes are correct or not? Otherwise we might have the wrong file in ipfs/ci-sync.