quic: add support for quic-go metrics #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending: quic-go patch release. |
sukunrt
force-pushed
the
quic-metrics
branch
3 times, most recently
from
f379090
to
e055461
Compare
MarcoPolo
reviewed
Jul 1, 2024
p2p/transport/quicreuse/options.go
Outdated
| @@ -10,9 +12,12 @@ func DisableReuseport() Option { | |||
| } | |||
|
|
|||
| // EnableMetrics enables Prometheus metrics collection. | |||
There was a problem hiding this comment.
Let's add to the comment saying if nil is passed, it will use the default registerer
MarcoPolo
approved these changes
Jul 1, 2024
|
Here's a run with full diff - https://github.com/libp2p/go-libp2p/actions/runs/9974916892/job/27563846282 I'll make sure we have the diff available on failures in the next release of uci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.