Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ignore protoc version comment on go generate #2631

Merged
merged 3 commits into from
Nov 14, 2023
Merged

ci: ignore protoc version comment on go generate #2631

merged 3 commits into from
Nov 14, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Nov 1, 2023 •
edited
Loading

Go generate leaves protoc version comments in some generated files. This PR ensures that we ignore it in the go check workflow.

@sukunrt
Copy link
Member

sukunrt commented Nov 2, 2023

Thanks @galargh

pedram0044
pedram0044 reviewed Nov 3, 2023
View reviewed changes
Copy link

@pedram0044 pedram0044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2631

@galargh galargh marked this pull request as ready for review November 14, 2023 14:54
@marten-seemann marten-seemann merged commit 5c95834 into master Nov 14, 2023
11 checks passed
@sukunrt sukunrt mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedram0044 pedram0044 pedram0044 left review comments

@sukunrt sukunrt sukunrt approved these changes

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galargh @sukunrt @marten-seemann @pedram0044