Refactor beginning #111
Merged
Refactor beginning #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: cluster/manager.go
|
@jvinod cli protobuf json stuff fixed |
|
You might want to check that I didnt mess up 632cfaf but this commit needs work |
…use of constants Signed-off-by: Peter Edge <[email protected]>
Signed-off-by: Peter Edge <[email protected]>
Signed-off-by: Peter Edge <[email protected]>
Signed-off-by: Peter Edge <[email protected]>
Signed-off-by: Peter Edge <[email protected]>
Signed-off-by: Peter Edge <[email protected]>
Fixed typo
This was referenced Feb 3, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of the refactor. I want to merge what there is so far sooner than later because the primary change here is moving the data objects to protobuf, which made a lot of changes in other places (especially around always using pointers). My hope is that we can "fully" test this (ie use your any internal testing you have with internal drivers) and then merge it.
We should talk about this change not over email.