Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out logrus as the logger #65

Closed
bufdev opened this issue Dec 14, 2015 · 6 comments
Closed

Switch out logrus as the logger #65

bufdev opened this issue Dec 14, 2015 · 6 comments

Comments

@bufdev
Copy link
Contributor

bufdev commented Dec 14, 2015

it is very slow

@bufdev
Copy link
Contributor Author

bufdev commented Dec 14, 2015

Two self-promotions here:

  • https://go.pedge.io/dlog is a package that puts an interface in front of logging packages. If you use dlog, you can use the stdlib logger, logrus, glog, and protolog.
  • https://go.pedge.io/protolog is a logger based on using structured events, represented as protocol buffers. It's insanely fast, and encourages good logging practices. It's been in use for a long time, but documentation is lacking.

@bufdev
Copy link
Contributor Author

bufdev commented Dec 14, 2015

One other strategy I have done in the past: https://github.com/grpc/grpc-go/tree/master/grpclog

@jvinod
Copy link
Contributor

jvinod commented Dec 15, 2015

I vote to stick with logrus - it does what we want it do - we use it's structured logging and is not in the i/o path. We can revisit this in the future if need be.

@bufdev
Copy link
Contributor Author

bufdev commented Jan 22, 2016

86471b3

@gourao
Copy link
Contributor

gourao commented Jan 25, 2016

@peter-edge No issues using dlog but can you submit a separate pull request for this (it's in refactor and refactor is very large to go through.)

@jvinod
Copy link
Contributor

jvinod commented Feb 3, 2016

merged #111

@jvinod jvinod closed this as completed Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants