Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #294: Added link to user profile under avatar on pledge detail #450

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

agateblue
Copy link

This is a real pull request this time, fixing an actual issue. As explained in #294, the pledge detail page was missing an explicit link. My implementation adds a link with an external-link icon from font-awesome, and with the text Profile on {platform}, as shown below:

screenshot from 2016-11-30 23-09-19

I'm not sure how to handle i18n though. Should I run a command to compile the new translation ?

@Changaco
Copy link
Member

Changaco commented Dec 1, 2016

Nice. :-)

i18n messages are extracted when we sync with Weblate (yeah, that's a mess), usually before deployment.

@Changaco Changaco merged commit b9c5d02 into liberapay:master Dec 1, 2016
@Changaco
Copy link
Member

Changaco commented Dec 1, 2016

I'm sending you an invite for the GitHub org and the Liberapay team (you should claim your username and fill your profile).

@agateblue agateblue deleted the user-profile-link branch December 1, 2016 09:21
@agateblue
Copy link
Author

Great thank you! I've seen a related issue regarding the workflow (#9) with translations. We are facing the same one at work (Git and weblate), I'll let you know if we find any suitable answer to this problem.

@Changaco
Copy link
Member

Changaco commented Dec 1, 2016

The only real solution would be to modify Weblate so that it regenerates commits automatically when there is a conflict. Problems with Weblate are listed in #75.

@Changaco
Copy link
Member

Changaco commented Dec 1, 2016

This is deployed. https://liberapay.com/on/github/EliotBerriot/

@agateblue
Copy link
Author

Wow, that was fast!

@Changaco
Copy link
Member

Changaco commented Dec 1, 2016

We don't have a staging environment so changes go straight to production. You can often see the effect of a PR a few minutes after it's been merged (here it was a few hours after because I didn't run release.sh immediately). Officially this was the 144th deployment this year (see releases), that's one every two or three days on average.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants