-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GitHub go routines #134
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9ce9773
refactor: broke apart the scraper into functions
a43aa52
chore: removed commented code
760132c
Merge branch 'main' into refactor-github-scraper
rhoofard 03027e0
fix: ran make fmt-all
e9a0940
feat: add go routines to github scraper
eed5e22
refactor: changed how the routines were setup
53a6454
Merge branch 'main' into add-github-go-routines
rhoofard 44094e7
feat: moved chunkSlice to helpers and added tests
1ee203d
fix: renamed buffer to fit caml case go convention
d4cef45
chore: cleanup commented out code from suggestions
adrielp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
168 changes: 115 additions & 53 deletions
168
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/generated-graphql.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff is a little confusing here. What's the change to the file & purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here I am switching the graphql query from edges to nodes like all the other queries. Also adding the repository name to the pull request and branch queries so I can keep track of it without having to create a custom struct to do that. The same is true with the default branch value for the branch query since the functions that process the data lost the context of which repo the branches are coming from and the default branch value with it.