Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub go routines #134

Merged
merged 10 commits into from
Oct 3, 2023
Merged

feat: Add GitHub go routines #134

merged 10 commits into from
Oct 3, 2023

Conversation

rhoofard
Copy link
Contributor

@rhoofard rhoofard commented Oct 2, 2023

No description provided.

@rhoofard rhoofard requested a review from a team as a code owner October 2, 2023 06:52
@github-actions github-actions bot added the go label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 252 lines in your changes are missing coverage. Please review.

Comparison is base (43fd4df) 44.26% compared to head (53a6454) 41.98%.
Report is 1 commits behind head on main.

❗ Current head 53a6454 differs from pull request most recent head d4cef45. Consider uploading reports for the commit d4cef45 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   44.26%   41.98%   -2.29%     
==========================================
  Files           9        9              
  Lines        1579     1665      +86     
==========================================
  Hits          699      699              
- Misses        869      955      +86     
  Partials       11       11              
Files Coverage Δ
...nternal/scraper/githubscraper/generated-graphql.go 0.00% <0.00%> (ø)
...r/internal/scraper/githubscraper/github_scraper.go 2.43% <0.00%> (-0.79%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhoofard rhoofard changed the title Add GitHub go routines feat: Add GitHub go routines Oct 2, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is a little confusing here. What's the change to the file & purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So here I am switching the graphql query from edges to nodes like all the other queries. Also adding the repository name to the pull request and branch queries so I can keep track of it without having to create a custom struct to do that. The same is true with the default branch value for the branch query since the functions that process the data lost the context of which repo the branches are coming from and the default branch value with it.

@adrielp adrielp merged commit a7a6525 into main Oct 3, 2023
8 checks passed
@adrielp adrielp deleted the add-github-go-routines branch October 3, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants