-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GitHub go routines #134
Conversation
Signed-off-by: Ryan Hoofard <[email protected]>
N producer 1 consumer for now. Also getting seg fault when recording merge time datapoint for some reason.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 44.26% 41.98% -2.29%
==========================================
Files 9 9
Lines 1579 1665 +86
==========================================
Hits 699 699
- Misses 869 955 +86
Partials 11 11
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff is a little confusing here. What's the change to the file & purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here I am switching the graphql query from edges to nodes like all the other queries. Also adding the repository name to the pull request and branch queries so I can keep track of it without having to create a custom struct to do that. The same is true with the default branch value for the branch query since the functions that process the data lost the context of which repo the branches are coming from and the default branch value with it.
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Outdated
Show resolved
Hide resolved
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Show resolved
Hide resolved
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Show resolved
Hide resolved
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Outdated
Show resolved
Hide resolved
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Outdated
Show resolved
Hide resolved
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Outdated
Show resolved
Hide resolved
pkg/receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Adriel Perkins <[email protected]>
No description provided.