-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At last, Transits v1 #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the config entry * Define the "omnibus" data type and function * Skeleton of the actual "transit activity" function
Yet another tangent on our way to transits
Can ask for it with the `Accept: text/plain` header: curl -vH "Accept: text/plain" "http://localhost:3000/full-chart?location=Your+Location&month=12&day=21&year=2020&hour=3&minute=18&day-part=pmz&lat=40.750284799999996&lng=-73.8787328"
* Note that the `exactAspectAngle` calculation may be off when close to 360/0! * Also, should the orb be configurable?
Already found some issues: * The 0/360 situation misses some aspects * Need to make Transit a superset of Aspect * `angularDifference` is wrong! * The orb situation is more subtle than I thought! Maybe it should be proportional to the planets involved? Maybe we use the usual orbs and then filter down aspects based on heuristics?
Have to consider the "counter-angle". Bit of a duplication here.
Note that for a transit to be active, it has to be within 1 degree.
Also, didn't need all those lenses, duh!
And show natal/transit positions in the transits page.
Should be usable in the natal chart page, too; though with more care: I'm using a few JS features not available in IE. Works in FF, Chrome and Safari tho.
Now the row is the transiting planet, for easier parsing!
Can be reused in natal chart page!
We were relying on some sorting that's not necessarily guaranteed. Probably need to do a similar thing for the natal chart!
* Look for all possible aspects, with the default orbs * Only draw exact aspects (looks a bit sparse!)
We consider a transit currently "triggered" when we've found a period of exactness in the 24 hours around the queried moment. Also, minute fixes to the table.
* The good: using sections and articles vs. those benighted dividers. * The bad: the asIcon' story is rather disappointing. Maybe Firmament _should_ provide Icons for Asc and MC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
There's been some work already introduced in #33 and #30, but the bulk is here:
article
,main
andsection
.Accept
header (so only really throughcurl
and friends,) but it's massively helpful for integration testing (easier to diff) and troubleshooting. Some dubious types were introduced here, so I'll surely iterate.