Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reskin chart #33

Merged
merged 19 commits into from
Dec 19, 2020
Merged

Reskin chart #33

merged 19 commits into from
Dec 19, 2020

Conversation

lfborjas
Copy link
Owner

@lfborjas lfborjas commented Dec 19, 2020 •
edited
Loading

Major refactor of chart UI, using styles from Firmament.

  • Updates failing tests from Index re-skin, unrelated housekeeping #32
  • Introduces a couple of ad-hoc styles (to address in the next version of firmament)
  • Hella markup changes in the Chart view
  • Makes the SVG generation output black-and-white images, all colors are to be applied through stylesheets.

Before

image
image

After

image
image

@lfborjas
Fix bottom navbar for Index
dfe5f3d 
Looks a tad goofy if there's overflow, but mostly alright.
@lfborjas
wip: update SVG generation of chart
7c3d31d 
Removes hardcoded colors (may bring back) in favor
of CSS as set by the hosting page. Moves the SVG test
fn to the `Dev` module.
@lfborjas
more wip on chart, styling
8615dcf
@lfborjas
Thickness and class corrections, brand in nav
f733415 
Introduces some inline styles to fix upstream
@lfborjas
Add guide lines to chart SVG
4de14e7
@lfborjas
Very tiny change to position lines
1c18590
@lfborjas
Signs heading, elemental colors
a4135e6
@lfborjas
Sort out tables
5a265cd
@lfborjas
Separate out general explanations
db1a71e
@lfborjas
Update firmament, minor style updates
84e4831 
Removes some ad-hoc styles in deference to upstream.
@lfborjas
discarded: fancy attrs
c9a6fb2
@lfborjas
More humble approach to explanation attributes
dcc9943
@lfborjas
Cards for zodiac signs
bcbafe2
@lfborjas
Cards for houses
257a3fe
@lfborjas
Planet cards
7048e63
@lfborjas
Cards for aspects
48a20cf
@lfborjas
Update golden files, remove unused bindings
6ca2e7f
@lfborjas
Mark Transit specs as pending
67f8981 
Bitten again by the linux v. macOS precision bug? Will fix when coming
back to transits.
@lfborjas
Update source code link
9ee9972
@lfborjas lfborjas merged commit 4f721f1 into master Dec 19, 2020
@lfborjas lfborjas deleted the reskin-chart branch December 19, 2020 02:11
@lfborjas lfborjas mentioned this pull request Dec 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lfborjas