docs: add doc for the configuration #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yisaer <[email protected]>
ngjaying
requested changes
Sep 21, 2023
| @@ -20,6 +20,14 @@ basic: | |||
| maxAge: 72 | |||
| # Whether to ignore case in SQL processing. Note that, the name of customized function by plugins are case-sensitive. | |||
| ignoreCase: false | |||
There was a problem hiding this comment.
I think we can add more descriptions. The cfgStorageType should be file and kv only. If kv is set, the real kv type is defined in the store section, which could be sqlite/redis and fdb in the future. Do not need to mention fdb for now.
Signed-off-by: yisaer <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2272 +/- ##
==========================================
- Coverage 62.83% 62.80% -0.03%
==========================================
Files 292 292
Lines 34995 34995
==========================================
- Hits 21988 21976 -12
- Misses 10976 10987 +11
- Partials 2031 2032 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: yisaer <[email protected]>
ngjaying
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.