-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cert): Support for extra TLS options #2258
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2258 +/- ##
==========================================
+ Coverage 62.79% 62.91% +0.12%
==========================================
Files 292 292
Lines 34995 35029 +34
==========================================
+ Hits 21972 22037 +65
+ Misses 10990 10958 -32
- Partials 2033 2034 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: Földi Tamás <[email protected]>
Signed-off-by: Földi Tamás <[email protected]>
Signed-off-by: Földi Tamás <[email protected]>
Signed-off-by: Földi Tamás <[email protected]>
Signed-off-by: Földi Tamás <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need to pass markdown check. Additionally, it'll be better to increase ut coverage to pass the condecov check. Thanks.
The markdown check fails in a file that I did not touch. Actually it is failing due to #2272 committed by @Yisaer two days ago (see https://github.com/lf-edge/ekuiper/actions/runs/6269824039/job/17026819627).
Locally, the markdown test passes so "it's not me, it's you" :)
For tests, sure, I can add tests for those lines. |
Ah, it's weird. The markdown check should have run in that PR. Never mind, we'll fix that. Appreciate your patience. |
plz update the base master branch as we have fixed the markdown lint error |
Signed-off-by: Földi Tamás <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. What a long run, thanks for the patience.
Signed-off-by: Földi Tamás <[email protected]>
Signed-off-by: Földi Tamás <[email protected]>
Support for extra SSL parameters for
mqtt
andhttp
sources. Fixes #2241