Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set integer literal size in SV backend #107

Merged
merged 2 commits into from
May 22, 2019
Merged

Conversation

leonardt
Copy link
Owner

Fixes issue introduced in StanfordAHA/lassen#95 where a 66 bit constant value was generated in system verilog and ncsim complained with:

inst = 21040819108348690454;
--
  | \|
  | ncvlog: *W,INTOVF (WrappedPE_tb.sv,37\|34): bit overflow during conversion from text [2.5(IEEE)] (32 bits).

This changes the system verilog backend to always emit the size of the integer literal using the <size>'d<value> syntax.

@coveralls
Copy link

coveralls commented May 22, 2019

Pull Request Test Coverage Report for Build 950

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 76.254%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fault/system_verilog_target.py 0 4 0.0%
Totals Coverage Status
Change from base Build 945: -0.1%
Covered Lines: 1368
Relevant Lines: 1794

💛 - Coveralls

@leonardt leonardt merged commit 3381904 into master May 22, 2019
@leonardt leonardt deleted the patch-sv-literals branch May 22, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants