-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in float logic #95
Conversation
@cdonovick @rdaly525 there seems to be a regression introduced by the new FP functional model. Reverting the functional model via this commit 2651391 fixes the RTL test for me, so that would suggest that the new FP functional model is exhibiting the incorrect behavior. |
Seems to be fixed by merging the changes in #92 |
@cdonovick now the fp tests are failing only when using the assembler (works when using the low level tuple interface), any hunches as to why this might be occurring? I'm going to poke around and see what the encoding values are |
I think I found the issue from the ncsim output:
need to format large integer literal in a way that ncsim accepts |
Issue fixed by fault generating the appropriate integer literal specifiers for width in this branch: leonardt/fault#107 |
In PR #81 the magma definition of the reinterpret functions did not perform the required type conversions, which caused the RTL to generate standard add/mul instead of float add/mul