Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in float logic #95

Merged
merged 6 commits into from
May 26, 2019
Merged

Fix regression in float logic #95

merged 6 commits into from
May 26, 2019

Conversation

leonardt
Copy link
Contributor

In PR #81 the magma definition of the reinterpret functions did not perform the required type conversions, which caused the RTL to generate standard add/mul instead of float add/mul

@leonardt leonardt requested review from rdaly525 and Kuree May 22, 2019 20:58
@leonardt
Copy link
Contributor Author

@cdonovick @rdaly525 there seems to be a regression introduced by the new FP functional model. Reverting the functional model via this commit 2651391 fixes the RTL test for me, so that would suggest that the new FP functional model is exhibiting the incorrect behavior.

@leonardt
Copy link
Contributor Author

Seems to be fixed by merging the changes in #92

@Kuree Kuree mentioned this pull request May 22, 2019
@leonardt
Copy link
Contributor Author

@cdonovick now the fp tests are failing only when using the assembler (works when using the low level tuple interface), any hunches as to why this might be occurring? I'm going to poke around and see what the encoding values are

@leonardt
Copy link
Contributor Author

I think I found the issue from the ncsim output:


inst = 21040819108348690454;
--
  | \|
  | ncvlog: *W,INTOVF (WrappedPE_tb.sv,37\|34): bit overflow during conversion from text [2.5(IEEE)] (32 bits).


need to format large integer literal in a way that ncsim accepts

@leonardt
Copy link
Contributor Author

Issue fixed by fault generating the appropriate integer literal specifiers for width in this branch: leonardt/fault#107

@leonardt leonardt changed the title Fix regression in m.BFloat conversion Fix regression in float logic May 22, 2019
@leonardt leonardt mentioned this pull request May 22, 2019
@Kuree Kuree merged commit fec72e6 into master May 26, 2019
@Kuree Kuree deleted the patch-magma-type-family branch May 26, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants