-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bitVec shiftLeft recurrences for bitblasting #4571
Merged
kim-em
merged 51 commits into
leanprover:master
from
opencompl:upstream-shiftLeft-recurrence
Jul 27, 2024
Merged
Changes from 47 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
2fde296
stash
bollu b60eb5f
chore: rebase
bollu 92fefe2
merge
bollu 640df34
chore: fix warnings
bollu f1a3738
chore: minimize delta in basic, lemmas
bollu d87babd
chore: minimize delta in bitblast
bollu 8ddb247
chore: cleanup, move lemmas to lemmas
bollu c775f5f
chore: move lemmas into lemmas
bollu 18af03d
chore: move lemmas
bollu f9275e0
Update src/Init/Data/BitVec/Bitblast.lean
bollu b8f8a6e
Update src/Init/Data/BitVec/Bitblast.lean
bollu 7d1918b
chore: add NOTE about extra hypothesis
bollu c22f3a6
chore: fix simp
bollu c4939d9
chore: fixup simp
bollu 51e0c09
chore: cleanup
bollu f5450ae
chore: cleanup proof
bollu fdeecb0
chore: fixup simp
bollu abb6c99
chore: fuse rw
bollu 0a6ed69
chore: fuse rw
bollu 0da724d
chore: squeeze proof
bollu 12b4082
chore: squeeze
bollu 0b5b6db
chore: mark unused hypothesis as inaccessible
bollu cb2b544
Update src/Init/Data/BitVec/Bitblast.lean
bollu cce9e8f
Update src/Init/Data/BitVec/Lemmas.lean
bollu 8009f75
chore: clean up proof of getLsb_ofNat_one to reuse getLsb_twoPow
bollu cebfe1b
chore: mark shiftLeft_eq' as a simp lemma
bollu 9a73edf
chore: delete duplicate lemmas
bollu b5f7a9b
chore: and_twoPow_eq -> and_twoPow. Also add twoPow_and
bollu 86ff901
chore: rephrase docstring, unsure if I got it right
bollu 38cd01c
Update src/Init/Data/BitVec/Bitblast.lean
bollu 5df7d21
chore: massively cleanup proof via Kim's strategy
bollu 0393592
Update src/Init/Data/BitVec/Lemmas.lean
bollu 6060574
chore: more cleanup
bollu 5651e3b
chore: move lemma from bitblast into lemma, and write docstrings
bollu 5981e7d
getLsb_ofNat_one -> getLsb_one
bollu 805d815
chore: add docstring for shiftLeft_eq_shiftLeftRec
bollu f70acdc
chore: replace have heq : ...; simp [heq] anti-pattern with suffices
bollu c4b9473
chore: don't pass explicit params where un-necessary
bollu 5ead5b4
chore: explain carry_of_and_eq_zero
bollu 568864f
chore: move addition lemma next to carry
bollu f76acf9
chore: un-simp twoPow_zero
bollu 83d367c
chore: final refactor
bollu c575ce8
chore: delete type ascription
bollu 50f34f9
chore: change w -> w₁
bollu e5f9a2d
chore: delete repeated the
bollu d980687
chore: update comments
bollu 47d51f9
chore: fix typo: w -> w₁
bollu 3af6a9d
Update src/Init/Data/BitVec/Lemmas.lean
tobiasgrosser 1517414
Update src/Init/Data/BitVec/Bitblast.lean
tobiasgrosser 67e676c
Update src/Init/Data/BitVec/Bitblast.lean
tobiasgrosser e0a827f
Finish renames
tobiasgrosser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toNat_add_of_and_eq_zero
will suffice: if there's only one sensible RHS, it doesn't need to be described in the name.